Re: [PATCH] perf/x86/uncore: Remove unnecessary check for uncore_pmu

On Wed 2019-11-13 05:35:02, kan.liang@linux.intel.com wrote:

From: Kan Liang kan.liang@linux.intel.com

The uncore_pmu pointer in uncore_pmu_enable/disable() is from container_of, which never be NULL.

Remove the unnecessary check for uncore_pmu.

Fixes: 75be6f703a14 ("perf/x86/uncore: Fix event group support") Reported-by: Pavel Machek pavel@denx.de Signed-off-by: Kan Liang kan.liang@linux.intel.com Cc: stable@vger.kernel.org

Sorry, sent email too fast.

I agree this is good fix for mainline, but as the code is a tiny bit ineffective but correct, I don't think we neccessarily need it in stable.

Best regards, Pavel