On 1/3/2022 6:23 AM, Greg Kroah-Hartman wrote:
From: Miaoqian Lin linmq006@gmail.com
[ Upstream commit b45396afa4177f2b1ddfeff7185da733fade1dc3 ]
The fixed_phy_get_gpiod function() returns NULL, it doesn't return error pointers, using NULL checking to fix this.i
Fixes: 5468e82f7034 ("net: phy: fixed-phy: Drop GPIO from fixed_phy_add()") Signed-off-by: Miaoqian Lin linmq006@gmail.com Link: https://lore.kernel.org/r/20211224021500.10362-1-linmq006@gmail.com Signed-off-by: Jakub Kicinski kuba@kernel.org Signed-off-by: Sasha Levin sashal@kernel.org
This patch prevents systems using fixed PHY devices from successfully registering, especially when those systems have a fixed PHY that does not use a GPIO:
[ 5.971952] brcm-systemport 9300000.ethernet: failed to register fixed PHY [ 5.978854] brcm-systemport: probe of 9300000.ethernet failed with error -22 [ 5.986047] brcm-systemport 9400000.ethernet: failed to register fixed PHY [ 5.992947] brcm-systemport: probe of 9400000.ethernet failed with error -22
Please drop it for now until it can be investigated. Thanks!