On 06.08.23 17:14, Hans de Goede wrote:
Commit a9c4a912b7dc ("ACPI: resource: Remove "Zen" specific match and quirks") is causing keyboard problems for quite a log of AMD based laptop users, leading to many bug reports.
Revert this change for now, until we can come up with a better fix for the PS/2 IRQ trigger-type/polarity problems on some x86 laptops.
Thx for this.
Fixes: a9c4a912b7dc ("ACPI: resource: Remove "Zen" specific match and quirks") Link: https://bugzilla.redhat.com/show_bug.cgi?id=2229165 Link: https://bugzilla.redhat.com/show_bug.cgi?id=2229317 Link: https://bugzilla.kernel.org/show_bug.cgi?id=217726
Not that it matters much, but there is at least one more:
https://lore.kernel.org/lkml/596b9c4a-fb83-a8ab-3a44-6052d83fa546@augustwike...
Cc: Mario Limonciello mario.limonciello@amd.com Cc: Linux regressions mailing list regressions@lists.linux.dev Cc: stable@vger.kernel.org Signed-off-by: Hans de Goede hdegoede@redhat.com
I tend to think this is the right thing to do. But for completeness to ensure everybody is aware of this: I'm pretty sure (Mario will know for sure) this will cause a regression for a few users, because a9c4a912b7dc was meant fixing a regression for them. Not sure how many users this might affect, but I guess it are at least those linked to in a9c4a912b7dc:
https://bugzilla.kernel.org/show_bug.cgi?id=217336 https://bugzilla.kernel.org/show_bug.cgi?id=217406 https://bugzilla.kernel.org/show_bug.cgi?id=217394
I assume that could be avoided by adding quirk entries for their machines. Some of the tickets have the data to do so.
Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) -- Everything you wanna know about Linux kernel regression tracking: https://linux-regtracking.leemhuis.info/about/#tldr If I did something stupid, please tell me, as explained on that page.