On 13.12.23 11:26, Ilpo Järvinen wrote:
On Sat, 9 Dec 2023, Lino Sanfilippo wrote:
In serial_omap_rs485() RS485 support may be deactivated due to a missing
There's no serial_omap_rs485() function. I assume/know you meant serial_omap_probe_rs485() but please correct.
Right, I meant serial_omap_probe_rs485(). Will fix the misnaming as well as the typos below.
RTS GPIO. This is done by nullifying the ports rs485_supported struct. After that however the serial_omap_rs485_supported struct is assigned to the same structure unconditionally, which results in an unintended reactivation of RS485 support.
Fix this by callling serial_omap_rs485() after the assignment of
callling -> calling.
Again, the function name is incorrect.
rs485_supported.
Wouldn't it be better if all rs485 init/setups would occur in the same place rather than being spread around? That is, move the rs485_config and rs485_supported setup into serial_omap_probe_rs485()?
No problem, I can do that. Thanks for the review(s)!
Regards, Lino