On Thu, Aug 29, 2024 at 05:26:39PM +0300, Andy Shevchenko wrote:
On Thu, Aug 29, 2024 at 5:23 PM Michael S. Tsirkin mst@redhat.com wrote:
On Thu, Aug 29, 2024 at 04:16:25PM +0200, Philipp Stanner wrote:
In psnet_open_pf_bar() and snet_open_vf_bar() a string later passed to pcim_iomap_regions() is placed on the stack. Neither pcim_iomap_regions() nor the functions it calls copy that string.
Should the string later ever be used, this, consequently, causes undefined behavior since the stack frame will by then have disappeared.
Fix the bug by allocating the strings on the heap through devm_kasprintf().
Cc: stable@vger.kernel.org # v6.3 Fixes: 51a8f9d7f587 ("virtio: vdpa: new SolidNET DPU driver.") Reported-by: Christophe JAILLET christophe.jaillet@wanadoo.fr Closes: https://lore.kernel.org/all/74e9109a-ac59-49e2-9b1d-d825c9c9f891@wanadoo.fr/ Suggested-by: Andy Shevchenko andy@kernel.org Signed-off-by: Philipp Stanner pstanner@redhat.com
Post this separately, so I can apply?
Don't you use `b4`? With it it as simple as
b4 am -P 6 $MSG_ID_OF_THIS_SERIES
-- With Best Regards, Andy Shevchenko
I can do all kind of things, but if it's posted as part of a patchset, it is not clear to me this has been tested outside of the patchset.