Re: [PATCH v2 01/38] backlight/bd6107: Compare against struct fb_info.device

On Mon, Jun 12, 2023 at 04:07:39PM +0200, Thomas Zimmermann wrote:

Struct bd6107_platform_data refers to a platform device within the Linux device hierarchy. The test in bd6107_backlight_check_fb() compares it against the fbdev device in struct fb_info.dev, which is different. Fix the test by comparing to struct fb_info.device.

Fixes a bug in the backlight driver and prepares fbdev for making struct fb_info.dev optional.

v2:

• move renames into separate patch (Javier, Sam, Michael)

Thanks. This helps a lot. I stared at this for a long time without seeing the fix. Then I misunderstood Sam's review comments (my fault, they were clear in retrospect) so I got completely lost.

regards, dan carpenter