18 Nov
2021
18 Nov
'21
4:17 p.m.
On Thu, Nov 18, 2021, Paolo Bonzini wrote:
On 11/18/21 10:56, Maxim Levitsky wrote:
vmx_sync_pir_to_irr has 'if (KVM_BUG_ON(!vcpu->arch.apicv_active, vcpu->kvm))' That has to be removed I think for this to work.
Good point.
Hmm, I think I'd prefer to keep it as
if (KVM_BUG_ON(!enable_apicv)) return -EIO;
since calling it directly or failing to nullify vmx_x86_ops.sync_pir_to_irr when APICv is unsupported would lead to all sorts of errors. It's not a strong preference though.