Re: [PATCH] soc: mmsys: mediatek: add mask to mmsys routes

Am 29. Juli 2021 05:15:23 MESZ schrieb Hsin-Yi Wang hsinyi@chromium.org:

This patch is breaking the mt8183 internal display. I think it's because ~routes[i].val; is removed? Also what should the routes[i].mask be if it's not set in mmsys_mt8183_routing_table?

...

                    writel_relaxed(reg, mmsys->regs +

routes[i].addr);

...

            }

}

<snip>

The mask should reset the needed bits,maybe it needs to be adjusted for your ddp components...

Can you add some debugs inside loops in mtk_mmsys_ddp_connect and mtk_mmsys_ddp_disconnect (show read val,mask and final mask before write) to show differences before and after the patch?

regards Frank