On Fri, May 25, 2018 at 03:32:12PM +0900, Daniel Sangorrin wrote:
Subject of the patch: xfs: remove racy hasattr check from attr ops Commit ID: 5a93790d4e2df73e30c965ec6e49be82fc3ccfce Why: It didn't pass LTP getxattr04 test, which is "a regression test for the race between getting an existing xattr and setting/removing a large xattr. This bug leads to that getxattr() fails to get an existing xattr and returns ENOATTR in xfs filesystem."
LTP test getxattr04 was FAILing with this error message: tst_device.c:230: INFO: Using test device LTP_DEV='/dev/loop0' tst_mkfs.c:83: INFO: Formatting /dev/loop0 with xfs opts='' extra opts='' tst_test.c:982: INFO: Timeout per run is 0h 05m 00s getxattr04.c:72: FAIL: getxattr() failed to get an existing attribute
After patching 4.4.y and running the test again (on x86_64) it PASSes: tst_device.c:230: INFO: Using test device LTP_DEV='/dev/loop0' tst_mkfs.c:83: INFO: Formatting /dev/loop0 with xfs opts='' extra opts='' tst_test.c:982: INFO: Timeout per run is 0h 05m 00s getxattr04.c:82: PASS: getxattr() succeeded to get an existing attribute
What kernel version: 4.4.y (Note: 4.9.y already has it applied)
Now applied, thanks.
greg k-h