From: Lars-Peter Clausen lars@metafoo.de
commit 265c82ea8b172129cb6d4eff41af856c3aff6168 upstream.
The tmag5273 gets a runtime PM reference before reading a measurement and releases it when done. But if the measurement fails the tmag5273_read_raw() function exits before releasing the reference.
Make sure that this error path also releases the runtime PM reference.
Fixes: 866a1389174b ("iio: magnetometer: add ti tmag5273 driver") Signed-off-by: Lars-Peter Clausen lars@metafoo.de Acked-by: Gerald Loacker gerald.loacker@wolfvision.net Reviewed-by: Nuno Sa nuno.sa@analog.com Link: https://lore.kernel.org/r/20230414013752.498767-1-lars@metafoo.de Cc: Stable@vger.kernel.org Signed-off-by: Jonathan Cameron Jonathan.Cameron@huawei.com Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org --- drivers/iio/magnetometer/tmag5273.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
--- a/drivers/iio/magnetometer/tmag5273.c +++ b/drivers/iio/magnetometer/tmag5273.c @@ -296,12 +296,13 @@ static int tmag5273_read_raw(struct iio_ return ret;
ret = tmag5273_get_measure(data, &t, &x, &y, &z, &angle, &magnitude); - if (ret) - return ret;
pm_runtime_mark_last_busy(data->dev); pm_runtime_put_autosuspend(data->dev);
+ if (ret) + return ret; + switch (chan->address) { case TEMPERATURE: *val = t;