Hi Fabio
Ah, I did not realize that amd compatible is present in the list and its quite a surprise.
/* * We don't know what's the best binding to link the gpu with the drm device. * Fow now, we just hunt for all the possible gpus that we support, and add them * as components. */ static const struct of_device_id msm_gpu_match[] = { { .compatible = "qcom,adreno" }, { .compatible = "qcom,adreno-3xx" }, { .compatible = "amd,imageon" }, { .compatible = "qcom,kgsl-3d0" }, { }, };
https://github.com/torvalds/linux/commit/e6f6d63ed14c20528aa6df05a8f0707c183...
For this change itself, Reviewed-by: Abhinav Kumar abhinavk@codeaurora.org
On 2021-09-16 09:24, Fabio Estevam wrote:
Hi Abhinav,
On Thu, Sep 16, 2021 at 1:15 PM abhinavk@codeaurora.org wrote:
Hi Fabio
Thanks for confirming.
Although I have no issues with your change, I am curious why even msm is probing and/or binding. Your device tree should not be having any mdp/dpu nodes then.
The i.MX53 does have the following GPU node:
compatible = "amd,imageon-200.0", "amd,imageon";
That's why it probes the msm driver.
However, i.MX53 does not have any of the Qualcomm display controllers.
It uses the i.MX IPU display controller instead.
Hope that clarifies.
Please reply with a Reviewed-by if you are happy with my fix.
Thanks