4.18-stable review patch. If anyone has any objections, please let me know.
------------------
From: Xin Long lucien.xin@gmail.com
[ Upstream commit 834539e69a5fe2aab33cc777ccfd4a4fcc5b9770 ]
After changing rhashtable_walk_start to return void, start_fail would never be set other value than 0, and the checking for start_fail is pointless, so remove it.
Fixes: 97a6ec4ac021 ("rhashtable: Change rhashtable_walk_start to return void") Signed-off-by: Xin Long lucien.xin@gmail.com Acked-by: Neil Horman nhorman@tuxdriver.com Acked-by: Marcelo Ricardo Leitner marcelo.leitner@gmail.com Signed-off-by: David S. Miller davem@davemloft.net Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org --- net/sctp/proc.c | 4 ---- 1 file changed, 4 deletions(-)
--- a/net/sctp/proc.c +++ b/net/sctp/proc.c @@ -215,7 +215,6 @@ static const struct seq_operations sctp_ struct sctp_ht_iter { struct seq_net_private p; struct rhashtable_iter hti; - int start_fail; };
static void *sctp_transport_seq_start(struct seq_file *seq, loff_t *pos) @@ -224,7 +223,6 @@ static void *sctp_transport_seq_start(st
sctp_transport_walk_start(&iter->hti);
- iter->start_fail = 0; return sctp_transport_get_idx(seq_file_net(seq), &iter->hti, *pos); }
@@ -232,8 +230,6 @@ static void sctp_transport_seq_stop(stru { struct sctp_ht_iter *iter = seq->private;
- if (iter->start_fail) - return; sctp_transport_walk_stop(&iter->hti); }