Re: [PATCH] net: Allow mac_pton() to work on non-NULL terminated strings

On Fri, 2018-02-23 at 23:41 +0300, Alexey Dobriyan wrote:

On Fri, Feb 23, 2018 at 09:17:48PM +0100, Stefan Hellermann wrote:

...

@@ -8,10 +8,6 @@ bool mac_pton(const char *s, u8 *mac) { int i;

• /* XX:XX:XX:XX:XX:XX */
• if (strlen(s) < 3 * ETH_ALEN - 1)

• return false;
  

• /* Don't dirty result unless string is valid MAC. */ for (i = 0; i < ETH_ALEN; i++) { if (!isxdigit(s[i * 3]) || !isxdigit(s[i * 3 + 1]))

Short string will bail in the loop, indeed.

Reviewed-by: Alexey Dobriyan adobriyan@gmail.com

Since the author is okay with the change, I'm following:

Reviewed-by: Andy Shevchenko andriy.shevchenko@linux.intel.com