Re: [PATCH v3] ceph: don't let check_caps skip sending responses for revoke msgs

On Wed, Jun 28, 2023 at 10:36 PM xiubli@redhat.com wrote:

From: Xiubo Li xiubli@redhat.com

If a client sends out a cap update dropping caps with the prior 'seq' just before an incoming cap revoke request, then the client may drop the revoke because it believes it's already released the requested capabilities.

This causes the MDS to wait indefinitely for the client to respond to the revoke. It's therefore always a good idea to ack the cap revoke request with the bumped up 'seq'.

Cc: stable@vger.kernel.org Link: https://tracker.ceph.com/issues/61782 Signed-off-by: Xiubo Li xiubli@redhat.com Reviewed-by: Milind Changire mchangir@redhat.com Signed-off-by: Ilya Dryomov idryomov@gmail.com

Reviewed-by: Patrick Donnelly pdonnell@redhat.com