On 2024-07-25 at 08:31:00, Shigeru Yoshida (syoshida@redhat.com) wrote:
On Thu, 25 Jul 2024 10:29:42 +0800, Ma Ke wrote:
It could lead to error happen because the variable res is not updated if the call to sr_share_read_word returns an error. In this particular case error code was returned and res stayed uninitialized. Same issue also applies to sr_read_reg.
This can be avoided by checking the return value of sr_share_read_word and sr_read_reg, and propagating the error if the read operation failed.
Found by code review.
Cc: stable@vger.kernel.org Fixes: c9b37458e956 ("USB2NET : SR9700 : One chip USB 1.1 USB2NET SR9700Device Driver Support") Signed-off-by: Ma Ke make24@iscas.ac.cn
I did a quick check for sr9700.c and there seems to be other suspicious usage of sr_read_reg(). But, for sr_mdio_read(), I think the patch is sufficient.
Reviewed-by: Shigeru Yoshida syoshida@redhat.com
Agree with Shigeru, may be you can submit another patch addressing "suspicious usage of sr_read_reg" this patch looks good
Reviewed-by: Hariprasad Kelam hkelam@marvell.com