Hi,
On 3/10/22 11:56, Rafael J. Wysocki wrote:
On Thu, Mar 10, 2022 at 10:07 AM Hans de Goede hdegoede@redhat.com wrote:
Hi,
On 3/9/22 19:27, Rafael J. Wysocki wrote:
On Wed, Mar 9, 2022 at 5:34 PM Rafael J. Wysocki rafael@kernel.org wrote:
On Wed, Mar 9, 2022 at 5:33 PM Hans de Goede hdegoede@redhat.com wrote:
Hi,
On 3/9/22 14:57, Rafael J. Wysocki wrote:
On Wed, Mar 9, 2022 at 2:44 PM Hans de Goede hdegoede@redhat.com wrote: > > Hi Rafael, > > We (Fedora) have been receiving a whole bunch of bug reports about > laptops getting hot/toasty while suspended with kernels >= 5.16.10 > and this seems to still happen with 5.17-rc7 too. > > The following are all bugzilla.redhat.com bug numbers: > > 1750910 - Laptop failed to suspend and completely drained the battery > 2050036 - Framework laptop: 5.16.5 breaks s2idle sleep > 2053957 - Package c-states never go below C2 > 2056729 - No lid events when closing lid / laptop does not suspend > 2057909 - Thinkpad X1C 9th in s2idle suspend still draining battery to zero over night , Ap > 2059668 - HP Envy Laptop deadlocks on entering suspend power state when plugged in. Case ge > 2059688 - Dell G15 5510 s2idle fails in 5.16.11 works in 5.16.10 > > And one of the bugs has also been mirrored at bugzilla.kernel.org by > the reporter: > > bko215641 - Dell G15 5510 s2idle fails in 5.16.11 works in 5.16.10 > > The common denominator here (besides the kernel version) seems to > be that these are all Ice or Tiger Lake systems (I did not do > check this applies 100% to all bugs, but it does see, to be a pattern). > > A similar arch-linux report: > > https://bbs.archlinux.org/viewtopic.php?id=274292&p=2 > > Suggest that reverting > "ACPI: PM: s2idle: Cancel wakeup before dispatching EC GPE" > > which was cherry-picked into 5.16.10 fixes things.
Thanks for letting me know!
> If you want I can create Fedora kernel test-rpms of a recent > 5.16.y with just that one commit reverted and ask users to > confirm if that helps. Please let me know if doing that woulkd > be useful ?
Yes, it would.
However, it follows from the arch-linux report linked above that 5.17-rc is fine, so it would be good to also check if reverting that commit from 5.17-rc helps.
Ok, I've done Fedora kernel builds of both 5.16.13 and 5.17-rc7 with the patch reverted and asked the bug-reporters to test both.
Thanks!
Also, in the cases where people have not tested 5.17-rc7 without any reverts, it would be good to ask them to do so.
Ok, done.
I have received another report related to this issue where the problem is not present in 5.17-rc7 (see https://lore.kernel.org/linux-pm/CAJZ5v0hKXyTtb1Jk=wqNV9_mZKdf3mmwF4bPOcmADy...).
The first results from the Fedora test kernel builds are in:
"HP Envy Laptop deadlocks on entering suspend power state when plugged in. Case gets very hot and requires a power button hold to restart" https://bugzilla.redhat.com/show_bug.cgi?id=2059668
5.16.9: good 5.16.10+: bad 5.16.13 with "ACPI: PM: s2idle: Cancel wakeup before dispatching EC GPE" reverted: good 5.17-rc7 with "ACPI: PM: s2idle: Cancel wakeup before dispatching EC GPE" reverted: good 5.17-rc7 (plain): good
So this seems to match the arch-linux report and the email report you linked. There is a problem with the backport in 5.16.10+, while 5.17-rc7 is fine.
It is likely that the commit in question actually depends on some other commits that were not backported into 5.16.y.
I was thinking the same thing, but I've no idea which commits that would be.
I do have an idea, but regardless of this, IMO the least risky way forward would be to request "stable" to drop "ACPI: PM: s2idle: Cancel wakeup before dispatching EC GPE" which has been backported, because it carried a Fixes tag and not because it was marked for "stable".
Let me do that.
Ok, that sounds good, thank you.
Regards,
Hans