On Wed, 2019-12-11 at 18:18 -0800, Dan Williams wrote:
On Wed, Dec 11, 2019 at 6:15 PM Dan Williams dan.j.williams@intel.com wrote:
On Wed, Dec 11, 2019 at 3:56 PM Jerry Snitselaar jsnitsel@redhat.com wrote:
Instead of repeatedly calling tpm_chip_start/tpm_chip_stop when issuing commands to the tpm during initialization, just reserve the chip after wait_startup, and release it when we are ready to call tpm_chip_register.
Cc: Christian Bundy christianbundy@fraction.io Cc: Dan Williams dan.j.williams@intel.com Cc: Peter Huewe peterhuewe@gmx.de Cc: Jarkko Sakkinen jarkko.sakkinen@linux.intel.com Cc: Jason Gunthorpe jgg@ziepe.ca Cc: Stefan Berger stefanb@linux.vnet.ibm.com Cc: stable@vger.kernel.org Cc: linux-integrity@vger.kernel.org Fixes: a3fbfae82b4c ("tpm: take TPM chip power gating out of tpm_transmit()") Fixes: 5b359c7c4372 ("tpm_tis_core: Turn on the TPM before probing IRQ's")
Ugh, sorry, I guess this jinxed it. This patch does not address the IRQ storm on the platform I reported earlier.
Are the reverts making their way upstream?
Not yet.
Cannot randomly apply patches without answer to why. Given that some changes are already landed changes it would be better to create a patch based on reverts (in the sense of code change) and commit message what is going on.
/Jarkko