On 2023-09-20 13:29, Greg Kroah-Hartman wrote:
4.14-stable review patch. If anyone has any objections, please let me know.
I already replied to the queuing e-mail but it was missed I guess. This patch should not get backported to the 4.14 due its dependencies. See below for more details.
-------- Original Message -------- Subject: Re: Patch "ARM: dts: BCM53573: Use updated "spi-gpio" binding properties" has been added to the 4.14-stable tree Date: 2023-09-11 09:04 From: Rafał Miłecki rafal@milecki.pl To: Sasha Levin sashal@kernel.org Cc: stable-commits@vger.kernel.org, Rob Herring robh+dt@kernel.org, Krzysztof Kozlowski krzysztof.kozlowski+dt@linaro.org, Conor Dooley conor+dt@kernel.org
On 2023-09-09 01:47, Sasha Levin wrote:
This is a note to let you know that I've just added the patch titled
ARM: dts: BCM53573: Use updated "spi-gpio" binding propertiesto the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git%3Ba=su...
The filename of the patch is: arm-dts-bcm53573-use-updated-spi-gpio-binding-proper.patch and it can be found in the queue-4.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let stable@vger.kernel.org know about it.
The new binding became part of Linux release 4.17-rc1 as a result of commits: 77a060533c04 ("spi: spi-gpio: Augment device tree bindings") 9b00bc7b901f ("spi: spi-gpio: Rewrite to use GPIO descriptors")
Kernels older than 4.17-rc1 don't support new binding.
This patch should NOT be backported to the 4.14.
commit 71f59fe710054f186fa145ba6134a95400585601 Author: Rafał Miłecki rafal@milecki.pl Date: Fri Jul 7 13:40:04 2023 +0200
ARM: dts: BCM53573: Use updated "spi-gpio" binding properties [ Upstream commit 2c0fd6b3d0778ceab40205315ccef74568490f17 ] Switch away from deprecated properties. This fixes: arch/arm/boot/dts/broadcom/bcm947189acdbmr.dtb: spi: gpio-sck:False schema does not allow [[3, 21, 0]] From schema: Documentation/devicetree/bindings/spi/spi-gpio.yaml arch/arm/boot/dts/broadcom/bcm947189acdbmr.dtb: spi: gpio-miso: False schema does not allow [[3, 22, 0]] From schema: Documentation/devicetree/bindings/spi/spi-gpio.yaml arch/arm/boot/dts/broadcom/bcm947189acdbmr.dtb: spi: gpio-mosi: False schema does not allow [[3, 23, 0]] From schema: Documentation/devicetree/bindings/spi/spi-gpio.yaml arch/arm/boot/dts/broadcom/bcm947189acdbmr.dtb: spi: 'sck-gpios' is a required property From schema: Documentation/devicetree/bindings/spi/spi-gpio.yaml arch/arm/boot/dts/broadcom/bcm947189acdbmr.dtb: spi: Unevaluated properties are not allowed ('gpio-miso', 'gpio-mosi', 'gpio-sck' were unexpected) From schema: Documentation/devicetree/bindings/spi/spi-gpio.yaml
Signed-off-by: Rafał Miłecki <rafal@milecki.pl> Link:https://lore.kernel.org/r/20230707114004.2740-4-zajec5@gmail.com Signed-off-by: Florian Fainelli florian.fainelli@broadcom.com Signed-off-by: Sasha Levin sashal@kernel.org
diff --git a/arch/arm/boot/dts/bcm947189acdbmr.dts b/arch/arm/boot/dts/bcm947189acdbmr.dts index ef263412fea51..02c916bedd281 100644 --- a/arch/arm/boot/dts/bcm947189acdbmr.dts +++ b/arch/arm/boot/dts/bcm947189acdbmr.dts @@ -61,9 +61,9 @@ wps { spi { compatible = "spi-gpio"; num-chipselects = <1>;
gpio-sck = <&chipcommon 21 0>;gpio-miso = <&chipcommon 22 0>;gpio-mosi = <&chipcommon 23 0>;
sck-gpios = <&chipcommon 21 0>;miso-gpios = <&chipcommon 22 0>;mosi-gpios = <&chipcommon 23 0>;