Re: [PATCH v2 01/11] drm/amd: Delay removal of the firmware framebuffer

Hello Mario,

On 12/28/22 17:30, Mario Limonciello wrote:

Removing the firmware framebuffer from the driver means that even if the driver doesn't support the IP blocks in a GPU it will no longer be functional after the driver fails to initialize.

This change will ensure that unsupported IP blocks at least cause the driver to work with the EFI framebuffer.

Cc: stable@vger.kernel.org Suggested-by: Alex Deucher alex.deucher@amd.com Signed-off-by: Mario Limonciello mario.limonciello@amd.com

---

As mentioned, I'm not familiar with this driver but the change looks good to me. Delaying the firmware-provided framebuffer removal is the correct thing to do IMO.

Reviewed-by: Javier Martinez Canillas javierm@redhat.com