Re: [PATCH V3 8/8] arm64: dts: qcom: Add camera clock controller for sm8150

31 Jul 2024


      On Wed, Jul 31, 2024 at 11:59:16AM GMT, Satya Priya Kakitapalli wrote:
...
Add device node for camera clock controller on Qualcomm
SM8150 platform.
Signed-off-by: Satya Priya Kakitapalli quic_skakitap@quicinc.com
arch/arm64/boot/dts/qcom/sa8155p.dtsi |  4 ++++
 arch/arm64/boot/dts/qcom/sm8150.dtsi  | 13 +++++++++++++
 2 files changed, 17 insertions(+)
Reviewed-by: Dmitry Baryshkov dmitry.baryshkov@linaro.org
Minor nit below.
...
@@ -3759,6 +3760,18 @@ camnoc_virt: interconnect@ac00000 {
   		qcom,bcm-voters = <&apps_bcm_voter>;
   	};

camcc: clock-controller@ad00000 {


	compatible = "qcom,sm8150-camcc";


	reg = <0 0x0ad00000 0 0x10000>;


	clocks = <&rpmhcc RPMH_CXO_CLK>,


		 <&gcc GCC_CAMERA_AHB_CLK>;


	power-domains = <&rpmhpd SM8150_MMCX>;


	required-opps = <&rpmhpd_opp_low_svs>;



Is the required-opps necessary?
...

	#clock-cells = <1>;


	#reset-cells = <1>;


	#power-domain-cells = <1>;


};


mdss: display-subsystem@ae00000 {
  	compatible = "qcom,sm8150-mdss";
  	reg = <0 0x0ae00000 0 0x1000>;

-- 
2.25.1
-- 
With best wishes
Dmitry


    

Signed-off-by: Satya Priya Kakitapalli quic_skakitap@quicinc.com