On 29/06/2018 16:55, Michal Hocko wrote:
I would also love to see a note how this memory is bound to the owner life time in the changelog. That would make the review much more easier.
--verbose for people that aren't well versed in linux mm, please...
Well, if the memory accounted to the memcg hits the hard limit and there is no way to reclaim anything to reduce the charged memory then we have to kill something. Hopefully the memory hog. If that one dies it would be great it releases its charges along the way. My remark was just to explain how that would happen for this specific type of memory. Bound to a file, has its own tear down etc. Basically make life of reviewers easier to understand the lifetime of charged objects without digging deep into the specific subsystem.
Oh I see. Yes, it's all freed when the VM file descriptor (which you get with a ioctl on /dev/kvm) is closed.
Thanks,
Paolo