Hi Daniel,
On 26/08/23 4:41 am, Daniel Díaz wrote:
Hello!
On Fri, 25 Aug 2023 at 10:17, Harshit Mogalapalli harshit.m.mogalapalli@oracle.com wrote:
These two are backports for 6.1.y. Conflict resolution in done in both patches. I have tested LTP-nfs fchown02 and chown02 on 6.1.y with below patches applied. The tests passed.
I have given this a go but did not see better results.
On 6.1.48-rc1, without any extra patches: https://lkft.validation.linaro.org/scheduler/job/6685964#L3814 https://storage.tuxsuite.com/public/linaro/lkft/builds/2UR2OCpseRQ0lu76phKZB...
On 6.1.48-rc1 plus this series of patches: https://lkft.validation.linaro.org/scheduler/job/6692637#L3832 https://lkft.validation.linaro.org/scheduler/job/6692642#L3818 https://storage.tuxsuite.com/public/linaro/daniel/builds/2UUHtMsTAQeuei3gGM3...
In both cases: chown02.c:46: TPASS: chown(testfile1, 0, 0) passed chown02.c:46: TPASS: chown(testfile2, 0, 0) passed chown02.c:58: TFAIL: testfile2: wrong mode permissions 0100700, expected 0102700 [...] fchown02.c:57: TPASS: fchown(3, 0, 0) passed fchown02.c:57: TPASS: fchown(4, 0, 0) passed fchown02.c:67: TFAIL: testfile2: wrong mode permissions 0100700, expected 0102700
The exact same thing happened with the 5.15 patch series.
Odd, I just tested 5.15 based kernel again.
Unpatched kernel:
<<<test_start>>> tag=fchown02 stime=1693034274 cmdline="fchown02" contacts="" analysis=exit <<<test_output>>> tst_test.c:1561: TINFO: Timeout per run is 0h 00m 30s fchown02.c:58: TPASS: fchown(3, 0, 0) passed fchown02.c:58: TPASS: fchown(4, 0, 0) passed fchown02.c:68: TFAIL: testfile2: wrong mode permissions 0100700, expected 0102700
Summary: passed 2 failed 1 broken 0 skipped 0 warnings 0
-----------
patched kernel:
<<<test_start>>> tag=fchown02 stime=1693034615 cmdline="fchown02" contacts="" analysis=exit <<<test_output>>> tst_test.c:1561: TINFO: Timeout per run is 0h 00m 30s fchown02.c:58: TPASS: fchown(3, 0, 0) passed fchown02.c:58: TPASS: fchown(4, 0, 0) passed
Summary: passed 2 failed 0 broken 0 skipped 0 warnings 0
Test steps:
mkdir /tmpdir
yum install nfs-utils -y echo "/media *(rw,no_root_squash,sync)" >/etc/exports systemctl start nfs-server.service mount -o rw,nfsvers=4 127.0.0.1:/media /tmpdir cd /opt/ltp/ ./runltp -d /tmpdir -s fchown02
Thanks for testing.
Regards, Harshit
I'll be glad to test more patches.
Greetings!
Daniel Díaz daniel.diaz@linaro.org
I would like to have a review as I am not familiar with this code.
Thanks to Vegard for helping me with this.
Thanks, Harshit
Christian Brauner (2): nfs: use vfs setgid helper nfsd: use vfs setgid helper
fs/attr.c | 1 + fs/internal.h | 2 -- fs/nfs/inode.c | 4 +--- fs/nfsd/vfs.c | 4 +++- include/linux/fs.h | 2 ++ 5 files changed, 7 insertions(+), 6 deletions(-)
-- 2.34.1