On Mon, 28 Apr 2025 20:44:14 -0400 Da Xue wrote:
On Fri, Apr 25, 2025 at 03:20:09PM -0400, Da Xue wrote:
This bit is necessary to receive packets from the internal PHY. Without this bit set, no activity occurs on the interface.
Normally u-boot sets this bit, but if u-boot is compiled without net support, the interface will be up but without any activity.
The vendor SDK sets this bit along with the PHY_ID bits.
I'd like to clarify that: Without this patch the writel the patch is modifying will clear the PHY_ID bit. But despite that the system works if at some point (uboot) set the PHY_ID bit?
Correct. If this is set once, it will work until the IP is powered down or reset. If u-boot does not set it, Linux will not set it and the IP will not work. If u-boot does set it, the IP will not work after suspend-resume since the IP is reset. Thus, we need to set it on the Linux side when bringing up the interface.
Added to the commit message when applying, thank you both!