Hi, Thorsten here, the Linux kernel's regression tracker. I'm not a proper reviewer for patches like this, but nevertheless two small things:
On 10.07.23 15:38, Christian Hesse wrote:
This device suffer an irq storm, so add it in tpm_tis_dmi_table to force polling.
Thx for working on this!
Not sure why this link might be helpful. Did you maybe mean to include another one? Like this one?
https://community.frame.work/t/boot-and-shutdown-hangs-with-arch-linux-kerne...
https://bugzilla.kernel.org/show_bug.cgi?id=217631
Fixes: e644b2f498d297a928efcb7ff6f900c27f8b788e
This should be:
Fixes: e644b2f498d ("tpm, tpm_tis: Enable interrupt test")
Cc: stable@vger.kernel.org Reported-by: roubro1991@gmail.com
The bugzilla link from above above should be here like this instead:
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217631
BTW, checkpatch.pl should have mentioned the two latter things.
HTH, Ciao, Thorsten
Signed-off-by: Christian Hesse mail@eworm.de
drivers/char/tpm/tpm_tis.c | 8 ++++++++ 1 file changed, 8 insertions(+)
diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c index 7db3593941ea..2979f8b9aaa0 100644 --- a/drivers/char/tpm/tpm_tis.c +++ b/drivers/char/tpm/tpm_tis.c @@ -114,6 +114,14 @@ static int tpm_tis_disable_irq(const struct dmi_system_id *d) } static const struct dmi_system_id tpm_tis_dmi_table[] = {
- {
.callback = tpm_tis_disable_irq,.ident = "Framework Laptop Intel 12th gen",.matches = {DMI_MATCH(DMI_SYS_VENDOR, "Framework"),DMI_MATCH(DMI_PRODUCT_VERSION, "A4"),},- }, { .callback = tpm_tis_disable_irq, .ident = "ThinkPad T490s",