Hi Chen-Yu,
The code path for Macs goes through bcm_apple_get_resources(), which skips over the code that sets up the regulator supplies. As a result, the call to regulator_bulk_enable() / regulator_bulk_disable() results in a NULL pointer dereference.
This was reported on the kernel.org Bugzilla, bug 202963.
Unbreak Broadcom Bluetooth support on Intel Macs by checking if the supplies were set up before enabling or disabling them.
The same does not need to be done for the clocks, as the common clock framework API checks for NULL pointers.
Fixes: 75d11676dccb ("Bluetooth: hci_bcm: Add support for regulator supplies") Cc: stable@vger.kernel.org # 5.0.x Signed-off-by: Chen-Yu Tsai wens@csie.org
I do not own a Mac, so this needs to be tested by someone else.
drivers/bluetooth/hci_bcm.c | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel