On Tue, Oct 31, 2023 at 05:11:27PM +0000, Mark Brown wrote:
On Tue, Oct 31, 2023 at 06:00:30PM +0100, Greg Kroah-Hartman wrote:
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void.
Trivially convert this driver from always returning zero in the remove callback to the void returning variant.
This doesn't seem like obvious stable material - it's not fixing any leaks or anything, just preparing for an API transition?
It was taken to make the patch after this one apply cleanly, that's all.
thanks,
greg k-h