Re: [PATCH v2] MIPS: Treat Loongson Extensions as ASEs

On 2019/5/29 下午10:27, Philippe Mathieu-Daudé wrote:

Hi Jiaxun,

On 5/29/19 10:42 AM, Jiaxun Yang wrote:

...

@@ -1950,6 +1954,8 @@ static inline void cpu_probe_loongson(struct cpuinfo_mips *c, unsigned int cpu) decode_configs(c); c->options |= MIPS_CPU_FTLB | MIPS_CPU_TLBINV | MIPS_CPU_LDPTE; c->writecombine = _CACHE_UNCACHED_ACCELERATED;

• c->ases |= (MIPS_ASE_LOONGSON_MMI | MIPS_ASE_LOONGSON_CAM |
  

• 	MIPS_ASE_LOONGSON_EXT | MIPS_ASE_LOONGSON_EXT2);
  

You announce the Loongson 2E/2F as supporting the EXTensions R2 ASE, are you sure this is correct?

Hi Phil

Only Loongson 3A R2/R3 support EXT2. In this case, cpu_probe_loongson() only set the cap for Loongson 3A R2/R3, since Loongson-2E/F have legacy format of PRID and it's handeld by cpu_probe_legacy().

Thanks.

---

Jiaxun Yang