Re: [PATCH 6.16.y 3/3] dt-bindings: serial: 8250: move a constraint

On 9/17/25 6:57 AM, Sasha Levin wrote:

From: Alex Elder elder@riscstar.com

[ Upstream commit 387d00028cccee7575f6416953bef62f849d83e3 ]

A block that required a "spacemit,k1-uart" compatible node to specify two clocks was placed in the wrong spot in the binding. Conor Dooley pointed out it belongs earlier in the file, as part of the initial "allOf".

Fixes: 2c0594f9f0629 ("dt-bindings: serial: 8250: support an optional second clock") Cc: stable stable@kernel.org Reported-by: Conor Dooley conor@kernel.org Closes: https://lore.kernel.org/lkml/20250729-reshuffle-contented-e6def76b540b@spud/ Signed-off-by: Alex Elder elder@riscstar.com Acked-by: Conor Dooley conor.dooley@microchip.com Link: https://lore.kernel.org/r/20250813032151.2330616-1-elder@riscstar.com Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org Signed-off-by: Sasha Levin sashal@kernel.org

Thank you Sasha, this fix looks good.

Acked-by: Alex Elder elder@riscstar.com

---

.../devicetree/bindings/serial/8250.yaml | 46 +++++++++---------- 1 file changed, 22 insertions(+), 24 deletions(-)

diff --git a/Documentation/devicetree/bindings/serial/8250.yaml b/Documentation/devicetree/bindings/serial/8250.yaml index e46bee8d25bf0..f59c0b37e8ebb 100644 --- a/Documentation/devicetree/bindings/serial/8250.yaml +++ b/Documentation/devicetree/bindings/serial/8250.yaml @@ -48,7 +48,6 @@ allOf: oneOf: - required: [ clock-frequency ] - required: [ clocks ]

• • if: properties: compatible:

@@ -66,6 +65,28 @@ allOf: items: - const: core - const: bus

• • if:

•  properties:
  

•    compatible:
  

•      contains:
  

•        enum:
  

•          - spacemit,k1-uart
  

•          - nxp,lpc1850-uart
  

• then:

•  required:
  

•    - clocks
  

•    - clock-names
  

•  properties:
  

•    clocks:
  

•      minItems: 2
  

•    clock-names:
  

•      minItems: 2
  

• else:

•  properties:
  

•    clocks:
  

•      maxItems: 1
  

•    clock-names:
  

•      maxItems: 1
  

properties: compatible: @@ -264,29 +285,6 @@ required: - reg - interrupts -if:

• properties:
• compatible:

•  contains:
  

•    enum:
  

•      - spacemit,k1-uart
  

•      - nxp,lpc1850-uart
  

-then:

• required:
• • clocks
• • clock-names
• properties:
• clocks:

•  minItems: 2
  

• clock-names:

•  minItems: 2
  

-else:

• properties:
• clocks:

•  maxItems: 1
  

• clock-names:

•  maxItems: 1
  

• unevaluatedProperties: false

examples: