On Mon, Apr 5, 2021 at 1:19 PM Saravana Kannan saravanak@google.com wrote:
On Mon, Apr 5, 2021 at 1:10 PM Ilya Lipnitskiy ilya.lipnitskiy@gmail.com wrote:
Hi Saravana,
On Mon, Apr 5, 2021 at 1:01 PM Saravana Kannan saravanak@google.com wrote:
On Sun, Apr 4, 2021 at 8:14 PM Ilya Lipnitskiy ilya.lipnitskiy@gmail.com wrote:
[<vendor>,]nr-gpios property is used by some GPIO drivers[0] to indicate the number of GPIOs present on a system, not define a GPIO. nr-gpios is not configured by #gpio-cells and can't be parsed along with other "*-gpios" properties.
scripts/dtc/checks.c also has a special case for nr-gpio{s}. However, nr-gpio is not really special, so we only need to fix nr-gpios suffix here.
The only example of this that I see is "snps,nr-gpios".
arch/arm64/boot/dts/apm/apm-shadowcat.dtsi uses "apm,nr-gpios", with parsing code in drivers/gpio/gpio-xgene-sb.c. There is also code in drivers/gpio/gpio-adnp.c and drivers/gpio/gpio-mockup.c using "nr-gpios" without any vendor prefix.
Ah ok. I just grepped the DT files. I'm not sure what Rob's position is on supporting DT files not in upstream. Thanks for the clarification.
For the offending drivers and docs that don't have any dts/dtsi files in-tree, can we just "sed -i 's/nr-gpios/ngpios'" and call it good?
Looks like even the DT spec has an exception only for vendor,nr and not just nr. https://github.com/devicetree-org/dt-schema/blob/master/schemas/gpio/gpio-co...
Thanks for linking the spec. I can re-spin the patch with ",nr-gpios" as the special suffix to align with the spec.
Ilya