The DC395x_* macros does not have white spaces between their arguments, and checkpatch.pl throws an error for each change in the macros. Adding white spaces between the arguments to fix the formatting.
Also, there are no surrounding parentheses in the expressions for the read macros, since these casts makes the expression a compound, which checkpatch.pl also complained about. Removing the type casts of the inb(), inw() and inl() calls. They now returns the expected type without explicit casting.
This patch does only formatting improvements to make the macro definitions align with the previous patch.
[1]: https://lore.kernel.org/linux-scsi/1ae97d061da14b0d85c0938c3000ed57ccd39382....
Signed-off-by: Xinhui Yang cyan@cyano.uk --- drivers/scsi/dc395x.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c index aed4f21e8143..1fb954180269 100644 --- a/drivers/scsi/dc395x.c +++ b/drivers/scsi/dc395x.c @@ -91,8 +91,8 @@ #endif
-#define DC395x_LOCK_IO(dev,flags) spin_lock_irqsave(((struct Scsi_Host *)dev)->host_lock, flags) -#define DC395x_UNLOCK_IO(dev,flags) spin_unlock_irqrestore(((struct Scsi_Host *)dev)->host_lock, flags) +#define DC395x_LOCK_IO(dev, flags) spin_lock_irqsave(((struct Scsi_Host *)dev)->host_lock, flags) +#define DC395x_UNLOCK_IO(dev, flags) spin_unlock_irqrestore(((struct Scsi_Host *)dev)->host_lock, flags)
/* * read operations that may trigger side effects in the hardware, @@ -100,12 +100,12 @@ */ #define DC395x_peek8(acb, address) ((void)(inb(acb->io_port_base + (address)))) /* normal read write operations goes here. */ -#define DC395x_read8(acb,address) (u8)(inb(acb->io_port_base + (address))) -#define DC395x_read16(acb,address) (u16)(inw(acb->io_port_base + (address))) -#define DC395x_read32(acb,address) (u32)(inl(acb->io_port_base + (address))) -#define DC395x_write8(acb,address,value) outb((value), acb->io_port_base + (address)) -#define DC395x_write16(acb,address,value) outw((value), acb->io_port_base + (address)) -#define DC395x_write32(acb,address,value) outl((value), acb->io_port_base + (address)) +#define DC395x_read8(acb, address) inb(acb->io_port_base + (address)) +#define DC395x_read16(acb, address) inw(acb->io_port_base + (address)) +#define DC395x_read32(acb, address) inl(acb->io_port_base + (address)) +#define DC395x_write8(acb, address, value) outb((value), acb->io_port_base + (address)) +#define DC395x_write16(acb, address, value) outw((value), acb->io_port_base + (address)) +#define DC395x_write32(acb, address, value) outl((value), acb->io_port_base + (address))
#define TAG_NONE 255