Re: [PATCH] crypto: qcom-rng - fix infinite loop on requests not multiple of WORD_SZ

On Tue, May 03, 2022 at 01:50:10PM +0200, Ondrej Mosnacek wrote:

The commit referenced in the Fixes tag removed the 'break' from the else branch in qcom_rng_read(), causing an infinite loop whenever 'max' is not a multiple of WORD_SZ. This can be reproduced e.g. by running:

kcapi-rng -b 67 >/dev/null

There are many ways to fix this without adding back the 'break', but they all seem more awkward than simply adding it back, so do just that.

Tested on a machine with Qualcomm Amberwing processor.

Fixes: a680b1832ced ("crypto: qcom-rng - ensure buffer for generate is completely filled") Cc: stable@vger.kernel.org Signed-off-by: Ondrej Mosnacek omosnace@redhat.com

Reviewed-by: Brian Masney bmasney@redhat.com

We should add '# 5.17+' to the end of the stable line.