The patch below does not apply to the 4.19-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to stable@vger.kernel.org.
Possible dependencies:
ff7cd07f3064 ("net: thunderbolt: Enable DMA paths only after rings are enabled") 180b0689425c ("thunderbolt: Allow multiple DMA tunnels over a single XDomain connection") 46b494f28681 ("thunderbolt: Add support for maxhopid XDomain property") 8ccbed2476f2 ("thunderbolt: Do not re-establish XDomain DMA paths automatically") d29c59b1a4dc ("thunderbolt: Add more logging to XDomain connections") 5ca67688256a ("thunderbolt: Allow disabling XDomain protocol") a27ea0dfc1cd ("thunderbolt: tunnel: Fix misspelling of 'receive_path'") 9490f71167fe ("thunderbolt: Add connection manager specific hooks for USB4 router operations") 83bab44ada05 ("thunderbolt: Pass TX and RX data directly to usb4_switch_op()") fe265a06319b ("thunderbolt: Pass metadata directly to usb4_switch_op()") 661b19473bf3 ("thunderbolt: Perform USB4 router NVM upgrade in two phases") edc0f494ed96 ("thunderbolt: Add DMA traffic test driver") 5bf722df5d37 ("thunderbolt: Make it possible to allocate one directional DMA tunnel") 5cc0df9ce10a ("thunderbolt: Add functions for enabling and disabling lane bonding on XDomain") 4210d50f0b3e ("thunderbolt: Add link_speed and link_width to XDomain") 47844ecb8cec ("thunderbolt: Create XDomain devices for loops back to the host") d67274bacb8a ("thunderbolt: Find XDomain by route instead of UUID") 8eabfca52333 ("thunderbolt: Use "if USB4" instead of "depends on" in Kconfig") 2c6ea4e2cefe ("thunderbolt: Allow KUnit tests to be built also when CONFIG_USB4=m") 54e418106c76 ("thunderbolt: Add debugfs interface")
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From ff7cd07f306406493f7b78890475e85b6d0811ed Mon Sep 17 00:00:00 2001 From: Mika Westerberg mika.westerberg@linux.intel.com Date: Tue, 30 Aug 2022 18:32:46 +0300 Subject: [PATCH] net: thunderbolt: Enable DMA paths only after rings are enabled
If the other host starts sending packets early on it is possible that we are still in the middle of populating the initial Rx ring packets to the ring. This causes the tbnet_poll() to mess over the queue and causes list corruption. This happens specifically when connected with macOS as it seems start sending various IP discovery packets as soon as its side of the paths are configured.
To prevent this we move the DMA path enabling to happen after we have primed the Rx ring. This makes sure no incoming packets can arrive before we are ready to handle them.
Fixes: e69b6c02b4c3 ("net: Add support for networking over Thunderbolt cable") Cc: stable@vger.kernel.org Signed-off-by: Mika Westerberg mika.westerberg@linux.intel.com Signed-off-by: David S. Miller davem@davemloft.net
diff --git a/drivers/net/thunderbolt.c b/drivers/net/thunderbolt.c index ff5d0e98a088..ab3f04562980 100644 --- a/drivers/net/thunderbolt.c +++ b/drivers/net/thunderbolt.c @@ -612,18 +612,13 @@ static void tbnet_connected_work(struct work_struct *work) return; }
- /* Both logins successful so enable the high-speed DMA paths and - * start the network device queue. + /* Both logins successful so enable the rings, high-speed DMA + * paths and start the network device queue. + * + * Note we enable the DMA paths last to make sure we have primed + * the Rx ring before any incoming packets are allowed to + * arrive. */ - ret = tb_xdomain_enable_paths(net->xd, net->local_transmit_path, - net->rx_ring.ring->hop, - net->remote_transmit_path, - net->tx_ring.ring->hop); - if (ret) { - netdev_err(net->dev, "failed to enable DMA paths\n"); - return; - } - tb_ring_start(net->tx_ring.ring); tb_ring_start(net->rx_ring.ring);
@@ -635,10 +630,21 @@ static void tbnet_connected_work(struct work_struct *work) if (ret) goto err_free_rx_buffers;
+ ret = tb_xdomain_enable_paths(net->xd, net->local_transmit_path, + net->rx_ring.ring->hop, + net->remote_transmit_path, + net->tx_ring.ring->hop); + if (ret) { + netdev_err(net->dev, "failed to enable DMA paths\n"); + goto err_free_tx_buffers; + } + netif_carrier_on(net->dev); netif_start_queue(net->dev); return;
+err_free_tx_buffers: + tbnet_free_buffers(&net->tx_ring); err_free_rx_buffers: tbnet_free_buffers(&net->rx_ring); err_stop_rings: