20 May
2024
20 May
'24
12:41 p.m.
On Fri, May 10, 2024 at 01:23:13PM -0700, Bart Van Assche wrote:
Both nbd_send_cmd() and nbd_handle_cmd() return either a negative error number or a positive blk_status_t value.
Eww. Please split these into separate values instead. There is a reason why blk_status_t is a separate type with sparse checks, and drivers really shouldn't do avoid with that for a tiny micro-optimization of the calling convention (if this even is one and not just the driver being sloppy).