Re: [PATCH v3] gpio: cdev: sanitize the label before requesting the interrupt

On Mon, Mar 25, 2024 at 10:02:42AM +0100, Bartosz Golaszewski wrote:

From: Bartosz Golaszewski bartosz.golaszewski@linaro.org

When an interrupt is requested, a procfs directory is created under "/proc/irq/<irqnum>/<label>" where <label> is the string passed to one of the request_irq() variants.

What follows is that the string must not contain the "/" character or the procfs mkdir operation will fail. We don't have such constraints for GPIO consumer labels which are used verbatim as interrupt labels for GPIO irqs. We must therefore sanitize the consumer string before requesting the interrupt.

Let's replace all "/" with ":".

Looks good to me.

Reviewed-by: Kent Gibson warthog618@gmail.com