On 2/6/22 04:09, Greg Kroah-Hartman wrote:
On Sat, Feb 05, 2022 at 10:41:08AM -0800, Guenter Roeck wrote:
Hi Greg,
On Sat, Feb 05, 2022 at 06:56:51PM +0100, Greg Kroah-Hartman wrote: [ ... ]
Yeah, something is really wrong here. I'm going to go revert this for now and push out a new set of releases with that fixed.
If you pull a release for that, can you possibly revert 9de2b9286a6 ("ASoC: mediatek: Check for error clk pointer") as well ? It does not realy fix anything but breaks pretty much all Mediatek systems using the mtk-scpsys driver. I sent a revert request https://lore.kernel.org/lkml/20220205014755.699603-1-linux@roeck-us.net/ but the it looks like the submitter keeps defending their patch. In the current state, pretty much all stable release starting with v4.19.y won't work for affected systems due to this patch.
I don't see anyone objecting to the revert in that thread (or any responses at all.) I'll queue up a revert for the next round of releases until this all gets worked out.
The discussion isn't easy to find, or at least I only found it after writing the revert. It is at
https://lore.kernel.org/all/trinity-2a727d96-0335-4d03-8f30-e22a0e10112d-164...
Guenter