Re: [PATCH net-next] virtio_net: drop netdev_tx_reset_queue() from virtnet_enable_queue_pair()

On Mon, 2 Dec 2024 12:22:53 +0800 Jason Wang wrote:

...

Fixes: c8bd1f7f3e61 ("virtio_net: add support for Byte Queue Limits") Cc: stable@vger.kernel.org # v6.11+ Signed-off-by: Koichiro Den koichiro.den@canonical.com

Acked-by: Jason Wang jasowang@redhat.com

I see Tx skb flush in:

virtnet_freeze() -> remove_vq_common() -> free_unused_bufs() -> virtnet_sq_free_unused_buf()

do we need to reset the BQL state in that case? Rule of thumb is netdev_tx_reset_queue() should follow any flush (IOW skb freeing not followed by netdev_tx_completed_queue()).