Re: [PATCH v2] usb: udc: core: Use lock when write to soft_connect

On Thu, Jan 14, 2021 at 09:03:53AM +0200, Andy Shevchenko wrote:

On Thursday, January 14, 2021, Ahmed S. Darwish a.darwish@linutronix.de wrote:

...

On Wed, Jan 13, 2021 at 07:38:28PM -0800, Thinh Nguyen wrote: ...

...

@@ -1543,10 +1546,12 @@ static ssize_t soft_connect_store(struct device

*dev,

...

          usb_gadget_udc_stop(udc);
  } else {
          dev_err(dev, "unsupported command '%s'\n", buf);

•         return -EINVAL;
  

•         ret = -EINVAL;
  }
  
  

• return n;
  

Should be ret = n; here.

Why? That happened higher up in the patch.

thanks,

greg k-h