6.5-stable review patch. If anyone has any objections, please let me know.
------------------
From: Frederick Lawler fred@cloudflare.com
commit 6b4b53ca0b7300ba2af98a49dbce22054bf034fe upstream.
Calls to lookup_user_key() require a corresponding key_put() to decrement the usage counter. Once it reaches zero, we schedule key GC. Therefore decrement struct key.usage in alg_set_by_key_serial().
Fixes: 7984ceb134bf ("crypto: af_alg - Support symmetric encryption via keyring keys") Cc: stable@vger.kernel.org Signed-off-by: Frederick Lawler fred@cloudflare.com Signed-off-by: Herbert Xu herbert@gondor.apana.org.au Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org --- crypto/af_alg.c | 3 +++ 1 file changed, 3 insertions(+)
--- a/crypto/af_alg.c +++ b/crypto/af_alg.c @@ -320,18 +320,21 @@ static int alg_setkey_by_key_serial(stru
if (IS_ERR(ret)) { up_read(&key->sem); + key_put(key); return PTR_ERR(ret); }
key_data = sock_kmalloc(&ask->sk, key_datalen, GFP_KERNEL); if (!key_data) { up_read(&key->sem); + key_put(key); return -ENOMEM; }
memcpy(key_data, ret, key_datalen);
up_read(&key->sem); + key_put(key);
err = type->setkey(ask->private, key_data, key_datalen);