From: Alexey Klimov alexey.klimov@linaro.org
[ Upstream commit 43e0da37d5cfb23eec6aeee9422f84d86621ce2b ]
We already have a component driver named "RX-MACRO", which is lpass-rx-macro.c. The tx macro component driver's name should be "TX-MACRO" accordingly. Fix it.
Cc: Srinivas Kandagatla srini@kernel.org Signed-off-by: Alexey Klimov alexey.klimov@linaro.org Reviewed-by: Neil Armstrong neil.armstrong@linaro.org Link: https://patch.msgid.link/20250806140030.691477-1-alexey.klimov@linaro.org Signed-off-by: Mark Brown broonie@kernel.org Signed-off-by: Sasha Levin sashal@kernel.org ---
LLM Generated explanations, may be completely bogus:
## Backport Status: **YES**
## Extensive Explanation:
This commit should be backported to stable kernel trees for the following reasons:
### 1. **Clear Bug Fix with User-Visible Impact** The commit fixes a copy-paste error where the TX macro codec driver incorrectly identified itself as "RX-MACRO" instead of "TX-MACRO". This bug has been present since the driver was initially introduced in commit c39667ddcfc5 ("ASoC: codecs: lpass-tx-macro: add support for lpass tx macro"). The incorrect component name causes: - **Debugfs confusion**: The component appears under `/sys/kernel/debug/asoc/` with the wrong name "RX-MACRO", making it indistinguishable from the actual RX macro driver - **Potential userspace issues**: Any userspace tools or scripts that rely on component names for identification would be confused - **Developer confusion**: When debugging audio issues, having two different components with the same name makes troubleshooting difficult
### 2. **Minimal and Contained Change** The fix is a simple one-line change that only modifies a string constant from "RX-MACRO" to "TX-MACRO" in the component driver structure. This is about as minimal as a fix can get: ```c - .name = "RX-MACRO", + .name = "TX-MACRO", ```
### 3. **No Risk of Regression** - The change only affects the component's identification string - It doesn't modify any functional behavior, audio paths, or driver logic - The correct name "TX-MACRO" is consistent with the driver's actual purpose (TX = transmit path) - Other similar macro drivers (WSA-MACRO, VA-MACRO) already use their correct respective names
### 4. **Long-Standing Issue** This bug has existed since the driver was first merged, meaning all kernel versions with this driver have the incorrect name. Backporting ensures consistency across all maintained kernel versions.
### 5. **Follows Stable Tree Rules** - **Important bug fix**: Yes - fixes component identification issue - **Minimal risk**: Yes - single string change with no functional impact - **Not a new feature**: Correct - purely a bug fix - **No architectural changes**: Correct - only changes a name string - **Clear and obvious fix**: Yes - the TX macro driver should be named "TX-MACRO", not "RX-MACRO"
### 6. **No Compatibility Concerns** While changing a component name could theoretically break userspace that depends on the incorrect name, this is unlikely because: - Having two components with identical names ("RX-MACRO") is already broken behavior - Any userspace relying on this would already be confused between the two components - The fix brings the driver in line with its intended design
The commit message clearly indicates this is a straightforward naming correction, and the code change confirms it's a minimal, safe fix suitable for stable backporting.
sound/soc/codecs/lpass-tx-macro.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/lpass-tx-macro.c b/sound/soc/codecs/lpass-tx-macro.c index 27bae58f4072..fe000ff522d2 100644 --- a/sound/soc/codecs/lpass-tx-macro.c +++ b/sound/soc/codecs/lpass-tx-macro.c @@ -2230,7 +2230,7 @@ static int tx_macro_register_mclk_output(struct tx_macro *tx) }
static const struct snd_soc_component_driver tx_macro_component_drv = { - .name = "RX-MACRO", + .name = "TX-MACRO", .probe = tx_macro_component_probe, .controls = tx_macro_snd_controls, .num_controls = ARRAY_SIZE(tx_macro_snd_controls),