On 3/6/24 19:24, Luis Henriques wrote:
xiubli@redhat.com writes:
From: Xiubo Li xiubli@redhat.com
The osd code has remove cursor initilizing code and this will make the sparse read state into a infinite loop. We should initialize the cursor just before each sparse-read in messnger v2.
Cc: stable@vger.kernel.org URL: https://tracker.ceph.com/issues/64607 Fixes: 8e46a2d068c9 ("libceph: just wait for more data to be available on the socket") Reported-by: Luis Henriques lhenriques@suse.de Signed-off-by: Xiubo Li xiubli@redhat.com
V2:
- Just removed the unnecessary 'sparse_read_total' check.
Thanks a lot for the quick fix, Xiubo. FWIW:
Tested-by: Luis Henriques lhenriques@suse.de
Note that I still see this test failing occasionally, but I haven't had time to help debugging it. And that's a different issue, of course. TBH I don't remember if this test ever used to reliably pass. Here's the output diff shown by fstests in case you're not able to reproduce it:
@@ -65,7 +65,7 @@ # Getting encryption key status Present (user_count=1, added_by_self) # Removing encryption key -Removed encryption key with identifier 69b2f6edeee720cce0577937eb8a6751 +Removed encryption key with identifier 69b2f6edeee720cce0577937eb8a6751, but files still busy # Getting encryption key status Absent # Verifying that the encrypted directory was "locked"
Thanks Luis.
This is a different issue as I remembered I have seen this before in msgr1.
Thanks
- Xiubo
Cheers,