On 11/16/2024 11:49 PM, Zijun Hu wrote:
For WCN6855, board ID specific NVM needs to be downloaded once board ID is available, but the default NVM is always downloaded currently, and the wrong NVM causes poor RF performance which effects user experience.
Hi Luiz,
could you please code review for this change ?
several types of product in market need this fix, hope it will go to mainline as early as possible.
sorry for this noise.
Fix by downloading board ID specific NVM if board ID is available.
Cc: Bjorn Andersson bjorande@quicinc.com Cc: Aiqun Yu (Maria) quic_aiquny@quicinc.com Cc: Cheng Jiang quic_chejiang@quicinc.com Cc: Johan Hovold johan@kernel.org Cc: Jens Glathe jens.glathe@oldschoolsolutions.biz Cc: Steev Klimaszewski steev@kali.org Cc: Paul Menzel pmenzel@molgen.mpg.de Fixes: 095327fede00 ("Bluetooth: hci_qca: Add support for QTI Bluetooth chip wcn6855") Cc: stable@vger.kernel.org # 6.4 Reviewed-by: Johan Hovold johan+linaro@kernel.org Tested-by: Johan Hovold johan+linaro@kernel.org Tested-by: Steev Klimaszewski steev@kali.org Tested-by: Jens Glathe jens.glathe@oldschoolsolutions.biz Signed-off-by: Zijun Hu quic_zijuhu@quicinc.com
Thank you Paul, Jens, Steev, Johan, Luiz for code review, various verification, comments and suggestions. these comments and suggestions are very good, and all of them are taken by this v2 patch.
Regarding the variant 'g', sorry for that i can say nothing due to confidential information (CCI), but fortunately, we don't need to care about its difference against one without 'g' from BT host perspective, qca_get_hsp_nvm_name_generic() shows how to map BT chip to firmware.
I will help to backport it to LTS kernels ASAP once this commit is mainlined.
Changes in v2:
- Correct subject and commit message
- Temporarily add nvm fallback logic to speed up backport.
— Add fix/stable tags as suggested by Luiz and Johan
v1-1-15af0aa2549c@quicinc.com