On Mon, Dec 09, 2024 at 12:12:05PM +0000, André Draszik wrote:
On Mon, 2024-12-09 at 13:05 +0100, Greg Kroah-Hartman wrote:
On Mon, Dec 09, 2024 at 11:50:57AM +0000, André Draszik wrote:
Before writing a new value to the register, the old value needs to be masked out for the new value to be programmed as intended, because at least in some cases the reset value of that field is 0xf (max value).
At the moment, the dwc3 core initialises the threshold to the maximum value (0xf), with the option to override it via a DT. No upstream DTs seem to override it, therefore this commit doesn't change behaviour for any upstream platform. Nevertheless, the code should be fixed to have the desired outcome.
Do so.
Fixes: 80caf7d21adc ("usb: dwc3: add lpm erratum support") Cc: stable@vger.kernel.org # 5.4 (needs adjustment for 5.10+) Signed-off-by: André Draszik andre.draszik@linaro.org
- has been marked as v2, to be in line with the 5.10+ patch
- for stable-5.10+, the if() test is slightly different, so a separate
patch has been sent for it for the patch to apply.
What is the git id of this in Linus's tree?
I guess I misunderstood the docs... It's not merged into Linus' tree yet - the proposed patch is here:
https://lore.kernel.org/all/20241209-dwc3-nyet-fix-v2-1-02755683345b@linaro....
Ah. Yeah, wait until it hits Linus's tree before telling us about this, otherwise we'll just get confused :)
thanks,
greg k-h