Hi Jason,
I love your patch! Yet something to improve:
[auto build test ERROR on ras/edac-for-next] [also build test ERROR on linus/master v6.1-rc5 next-20221115] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Jason-Baron/EDAC-edac_module-... base: https://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git edac-for-next patch link: https://lore.kernel.org/r/20221116003729.194802-1-jbaron%40akamai.com patch subject: [PATCH] EDAC/edac_module: order edac_init() before ghes_edac_register() config: powerpc-allyesconfig compiler: powerpc-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/a970ee7e983345d07bd1f3e455688e... git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Jason-Baron/EDAC-edac_module-order-edac_init-before-ghes_edac_register/20221116-084046 git checkout a970ee7e983345d07bd1f3e455688ef753f32a45 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash drivers/
If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot lkp@intel.com
All errors (new ones prefixed by >>):
drivers/edac/edac_module.c: In function 'edac_init_clear_parity_errors': drivers/edac/edac_module.c:162:16: error: 'return' with a value, in function returning void [-Werror=return-type] 162 | return 0; | ^ drivers/edac/edac_module.c:151:20: note: declared here 151 | static void __init edac_init_clear_parity_errors(void) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from include/linux/printk.h:6, from include/asm-generic/bug.h:22, from arch/powerpc/include/asm/bug.h:158, from include/linux/bug.h:5, from arch/powerpc/include/asm/cmpxchg.h:8, from arch/powerpc/include/asm/atomic.h:11, from include/linux/atomic.h:7, from include/linux/edac.h:15, from drivers/edac/edac_module.c:13: drivers/edac/edac_module.c: At top level:
drivers/edac/edac_module.c:177:17: error: initialization of 'initcall_t' {aka 'int (*)(void)'} from incompatible pointer type 'void (*)(void)' [-Werror=incompatible-pointer-types]
177 | subsys_initcall(edac_init_clear_parity_errors); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/init.h:250:55: note: in definition of macro '____define_initcall' 250 | __attribute__((__section__(__sec))) = fn; | ^~ include/linux/init.h:260:9: note: in expansion of macro '__unique_initcall' 260 | __unique_initcall(fn, id, __sec, __initcall_id(fn)) | ^~~~~~~~~~~~~~~~~ include/linux/init.h:262:35: note: in expansion of macro '___define_initcall' 262 | #define __define_initcall(fn, id) ___define_initcall(fn, id, .initcall##id) | ^~~~~~~~~~~~~~~~~~ include/linux/init.h:286:41: note: in expansion of macro '__define_initcall' 286 | #define subsys_initcall(fn) __define_initcall(fn, 4) | ^~~~~~~~~~~~~~~~~ drivers/edac/edac_module.c:177:1: note: in expansion of macro 'subsys_initcall' 177 | subsys_initcall(edac_init_clear_parity_errors); | ^~~~~~~~~~~~~~~ cc1: some warnings being treated as errors
vim +177 drivers/edac/edac_module.c
173 174 /* 175 * Clear parity errors after PCI subsys is initialized 176 */
177 subsys_initcall(edac_init_clear_parity_errors);
178