Hi Matt,
On 23.4.2018 15:21, Matt Redfearn wrote:
Hi Michal
On 23/04/18 10:18, Michal Simek wrote:
device->baud is always non zero value because it is checked already in early_serial8250_setup() before init_port is called.
True, currently init_port is only called from the one location and so the test is a little redundant, though I don't see the harm in testing both inputs to the divisor calculation immediately before use such that any future call path avoids setting a bad divisor.
I will let others to decide.
Fixes: 0ff3ab701963 ("serial: 8250_early: Only set divisor if valid clk & baud") Cc: stable stable@vger.kernel.org
Even if the test is dropped going forward, I wouldn't consider it's presence a "bug" such that a fix needs to be backported.
Not a problem with not adding this to stable.
Thanks, Michal