On Thu, Jun 09, 2022 at 10:45:56AM +0200, Michal Hocko wrote:
On Thu 09-06-22 12:03:42, Muchun Song wrote:
"numa_stat" should not be included in the scope of CONFIG_HUGETLB_PAGE, if CONFIG_HUGETLB_PAGE is not configured even if CONFIG_NUMA is configured, "numa_stat" is missed form /proc. Remove it out of CONFIG_HUGETLB_PAGE and move numa_stat sysctl handling to mm/vmstat.c.
Fixes: 4518085e127d ("mm, sysctl: make NUMA stats configurable") Signed-off-by: Muchun Song songmuchun@bytedance.com Cc: stable@vger.kernel.org
It really looks like numa_stat is misplaced but I am wondering why the fix cannot be as simple as
Your changes LGTM. I think I have overdone it. I really should seprate this into two separate patches, one is bug fix (just like your changes), another is simplify the code further. I'll rework this patch.
Thanks.