From: Matouš Lánský matouslansky@post.cz
[ Upstream commit 9be25402d8522e16e5ebe84f2b1b6c5de082a388 ]
Add headset mic quirk for Acer Nitro AN517-55. This laptop uses the same audio configuration as the AN515-58 model.
Signed-off-by: Matouš Lánský matouslansky@post.cz Link: https://patch.msgid.link/20251231171207.76943-1-matouslansky@post.cz Signed-off-by: Takashi Iwai tiwai@suse.de Signed-off-by: Sasha Levin sashal@kernel.org ---
LLM Generated explanations, may be completely bogus:
## Commit Analysis: ALSA: hda/realtek: Add quirk for Acer Nitro AN517-55
### 1. COMMIT MESSAGE ANALYSIS
The commit adds a headset mic quirk for the Acer Nitro AN517-55 laptop. The message clearly states this laptop uses the same audio configuration as the AN515-58 model, which already has a quirk entry. The commit has proper sign-offs from the submitter and the ALSA maintainer (Takashi Iwai).
### 2. CODE CHANGE ANALYSIS
The change is a **single line addition** to the quirk table in `sound/hda/codecs/realtek/alc269.c`:
```c SND_PCI_QUIRK(0x1025, 0x1597, "Acer Nitro 5 AN517-55", ALC2XX_FIXUP_HEADSET_MIC), ```
Breaking this down: - `0x1025` - Acer's PCI vendor ID - `0x1597` - Subsystem ID for the AN517-55 model - `ALC2XX_FIXUP_HEADSET_MIC` - The fixup to enable headset microphone support
Looking at the context, the line immediately above is: ```c SND_PCI_QUIRK(0x1025, 0x159c, "Acer Nitro 5 AN515-58", ALC2XX_FIXUP_HEADSET_MIC), ```
This confirms the AN517-55 uses the identical fixup as the AN515-58, which is already proven to work.
### 3. CLASSIFICATION
This is a **HARDWARE QUIRK** - one of the explicitly allowed exceptions for stable backports. It: - Adds a PCI subsystem ID to an existing quirk table - Uses an already-established fixup mechanism - Does NOT add any new code logic or features
### 4. SCOPE AND RISK ASSESSMENT
- **Lines changed:** 1 - **Files touched:** 1 - **Complexity:** Trivial - table entry addition - **Risk:** **Essentially zero** - This quirk entry ONLY affects devices with the exact PCI subsystem ID 0x1025:0x1597. It cannot possibly impact any other hardware.
### 5. USER IMPACT
- **Problem:** Headset microphone doesn't work on Acer Nitro AN517-55 laptops without this quirk - **Users affected:** Anyone with this specific laptop model who wants to use a headset with microphone - **Severity:** This is a genuine hardware functionality bug - the mic input doesn't work without the quirk - **Real-world impact:** Affects video calls, gaming chat, voice recording, etc.
### 6. STABILITY INDICATORS
- Signed off by Takashi Iwai (the ALSA maintainer) - The `ALC2XX_FIXUP_HEADSET_MIC` fixup is well-established and used by many similar Acer models - Pattern is identical to hundreds of other quirk entries in this file
### 7. DEPENDENCY CHECK
- **No dependencies** - the fixup being referenced already exists in stable kernels - Will apply cleanly to any kernel with the HDA Realtek codec driver - The quirk infrastructure has been stable for many years
## Conclusion
This is a **textbook stable backport candidate**:
1. **Fixes a real bug:** Headset mic doesn't work without it 2. **Obviously correct:** Identical to existing entry for similar hardware 3. **Small and contained:** Single line addition to a quirk table 4. **No new features:** Enables existing functionality for a new device ID 5. **Zero regression risk:** Only affects this specific laptop model 6. **Explicitly allowed:** Hardware quirks are called out as stable- appropriate in the rules
The stable kernel rules explicitly permit hardware quirks because they fix real issues for specific hardware with essentially zero risk to other systems. Users of this laptop on stable kernels would otherwise have non-functional headset mic support until they upgrade to a newer kernel.
**YES**
sound/hda/codecs/realtek/alc269.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c index b3582e390dfa3..705d6acc204cf 100644 --- a/sound/hda/codecs/realtek/alc269.c +++ b/sound/hda/codecs/realtek/alc269.c @@ -6239,6 +6239,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1025, 0x1466, "Acer Aspire A515-56", ALC255_FIXUP_ACER_HEADPHONE_AND_MIC), SND_PCI_QUIRK(0x1025, 0x1534, "Acer Predator PH315-54", ALC255_FIXUP_ACER_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1025, 0x159c, "Acer Nitro 5 AN515-58", ALC2XX_FIXUP_HEADSET_MIC), + SND_PCI_QUIRK(0x1025, 0x1597, "Acer Nitro 5 AN517-55", ALC2XX_FIXUP_HEADSET_MIC), SND_PCI_QUIRK(0x1025, 0x169a, "Acer Swift SFG16", ALC256_FIXUP_ACER_SFG16_MICMUTE_LED), SND_PCI_QUIRK(0x1025, 0x1826, "Acer Helios ZPC", ALC287_FIXUP_PREDATOR_SPK_CS35L41_I2C_2), SND_PCI_QUIRK(0x1025, 0x182c, "Acer Helios ZPD", ALC287_FIXUP_PREDATOR_SPK_CS35L41_I2C_2),