Re: [PATCH 2/4] btrfs: fix the error handling for submit_extent_page() for btrfs_do_readpage()

On Mon, Apr 11, 2022 at 02:12:50PM +0800, Qu Wenruo wrote:

[BUG] Test case generic/475 have a very high chance (almost 100%) to hit a fs hang, where a data page will never be unlocked and hang all later operations.

Question: how can we even get an error? The submission already stopped return errors with patch 1. btrfs_get_chunk_map called from btrfs_zoned_get_device and calc_bio_boundaries really just has sanity checks that should be fatal if not met, same for btrfs_get_io_geometry.

So yes, we could fix the nasty error handling here. Or just remove it entirely, which would reduce the possibility of bugs even more.