Hi Kees,
I love your patch! Yet something to improve:
[auto build test ERROR on kees/for-next/pstore] [also build test ERROR on kees/for-next/kspp linus/master v6.2-rc2 next-20230105] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Kees-Cook/io_uring-Replace-0-... base: https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/pstore patch link: https://lore.kernel.org/r/20230105033743.never.628-kees%40kernel.org patch subject: [PATCH] io_uring: Replace 0-length array with flexible array config: x86_64-rhel-8.3-rust compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/6239ffe2f8611e707b90e0c902bfa1... git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Kees-Cook/io_uring-Replace-0-length-array-with-flexible-array/20230105-114008 git checkout 6239ffe2f8611e707b90e0c902bfa1f0dbe578bb # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/nvme/host/
If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot lkp@intel.com
All errors (new ones prefixed by >>):
In file included from drivers/nvme/host/ioctl.c:8: In file included from include/linux/io_uring.h:7:
include/uapi/linux/io_uring.h:628:23: error: flexible array member 'bufs' in a union is not allowed
struct io_uring_buf bufs[]; ^ 1 error generated.
vim +/bufs +628 include/uapi/linux/io_uring.h
615 616 struct io_uring_buf_ring { 617 union { 618 /* 619 * To avoid spilling into more pages than we need to, the 620 * ring tail is overlaid with the io_uring_buf->resv field. 621 */ 622 struct { 623 __u64 resv1; 624 __u32 resv2; 625 __u16 resv3; 626 __u16 tail; 627 };
628 struct io_uring_buf bufs[];
629 }; 630 }; 631