Re: [PATCH] pinctrl: airoha: fix wrong PHY LED mapping and PHY2 LED defines

On 2025-03-26 13:23, Christian Marangi wrote:

The current PHY2 LED define are wrong and actually set BITs outside the related mask. Fix it and set the correct value. While at it, also use FIELD_PREP_CONST macro to make it simple to understand what values are actually applied for the mask.

Also fix wrong PHY LED mapping. The SoC Switch supports up to 4 port but the register define mapping for 5 PHY port, starting from 0. The mapping was wrongly defined starting from PHY1. Reorder the function group to start from PHY0. PHY4 is actually never supported as we don't have a GPIO pin to assign.

Reviewed-by: Benjamin Larsson benjamin.larsson@genexis.eu