Re: [PATCH] ALSA: hda: intel-dsp-config: Fix Huawei Matebook D14 NBLB-WAX9N quirk detection

On Thu, Apr 18, 2024 at 09:48:27AM +0100, Mauro Carvalho Chehab wrote:

Newer Matebook D14 model comes with essx8336 and supports SOF, but the initial models use the legacy driver, with a Realtek ALC 256 AC97 chip on it.

The BIOS seems to be prepared to be used by both models, so it contains an entry for ESSX8336 on its DSDT table.

Add a quirk, as otherwise dspconfig driver will try to load SOF, causing audio probe to fail.

...

• 		.ident = "Huawei NBLB-WAX9N",
  

• 		.matches = {
  

• 			DMI_MATCH(DMI_SYS_VENDOR, "HUAWEI"),
  

• 			DMI_MATCH(DMI_PRODUCT_NAME, "NBLB-WAX9N"),
  

• 		}
  

I would leave a trailing comma to avoid unneeded churn in the future in case this gets extended.

• 	},
  

• 	{}
  

• }
  

Ditto.

• },